Re: Coding style using shared_ptr

Stephan Bergmann <sbergman -AT- redhat.com>

Thu, 2 Jun 2016 10:23:09 +0200

On 06/01/2016 09:33 AM, Aptitude Testing Team wrote:

We have an inconsistency with the coding style in our shared_ptr typedefs

cd core/include; grep -R "typedef std::shared_ptr"

Shows (for "std::shared_ptr<Foo>") we have "FooPtr" or "FooRef" or "PFoo"

Should we standardise this?

FooPtr is my preference.

...and std::shared_ptr<Foo> is mine. (That is, most of the time I find

such trivial typedefs to be more of a distraction ("what's that FooPtr

thing? a plain *, some std smart ptr, or maybe an rtl::Reference? lets

look it up") than a help. I think we even have an EasyHack to get rid

of them.)

Context

Coding style using shared_ptr · Aptitude Testing Team

Re: Coding style using shared_ptr · Stephan Bergmann
- Re: Coding style using shared_ptr · Tor Lillqvist

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.