New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1362177:  Memory - corruptions  (USE_AFTER_FREE)
/formula/source/core/api/token.cxx: 1474 in formula::FormulaTokenArray::RewriteMissing(const 
formula::MissingConvention &)()


________________________________________________________________________________________________________
*** CID 1362177:  Memory - corruptions  (USE_AFTER_FREE)
/formula/source/core/api/token.cxx: 1474 in formula::FormulaTokenArray::RewriteMissing(const 
formula::MissingConvention &)()
1468             }
1469         }
1470     
1471         if (pOcds != &aOpCodeDcountStack[0])
1472             delete [] pOcas;
1473         if (pOcas != &aOpCodeAddressStack[0])
> > >     CID 1362177:  Memory - corruptions  (USE_AFTER_FREE)
> > >     Calling "operator delete[]" frees pointer "pOcas" which has already been freed. [Note: The 
> > > source code implementation of the function has been overridden by a builtin model.]
1474             delete [] pOcas;
1475         if (pCtx != &aCtx[0])
1476             delete [] pCtx;
1477     
1478         return pNewArr;
1479     }

** CID 1362176:  Uninitialized members  (UNINIT_CTOR)
/framework/source/uiconfiguration/imagemanagerimpl.cxx: 525 in 
framework::ImageManagerImpl::ImageManagerImpl(const 
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, cppu::OWeakObject *, 
bool)()


________________________________________________________________________________________________________
*** CID 1362176:  Uninitialized members  (UNINIT_CTOR)
/framework/source/uiconfiguration/imagemanagerimpl.cxx: 525 in 
framework::ImageManagerImpl::ImageManagerImpl(const 
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, cppu::OWeakObject *, 
bool)()
519     {
520         for ( vcl::ImageType n : o3tl::enumrange<vcl::ImageType>() )
521         {
522             m_pUserImageList[n] = nullptr;
523             m_bUserImageListModified[n] = false;
524         }
> > >     CID 1362176:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member field "m_pUserImageList.detail_values" is not initialized in this 
> > > constructor nor in any functions that it calls.
525     }
526     
527     ImageManagerImpl::~ImageManagerImpl()
528     {
529         clear();
530     }

** CID 1362175:  Uninitialized members  (UNINIT_CTOR)
/sw/source/uibase/sidebar/PageMarginPanel.cxx: 77 in 
sw::sidebar::PageMarginPanel::PageMarginPanel(vcl::Window *, const 
com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)()


________________________________________________________________________________________________________
*** CID 1362175:  Uninitialized members  (UNINIT_CTOR)
/sw/source/uibase/sidebar/PageMarginPanel.cxx: 77 in 
sw::sidebar::PageMarginPanel::PageMarginPanel(vcl::Window *, const 
com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)()
71         get(mpLeftMarginEdit, "leftmargin");
72         get(mpRightMarginEdit, "rightmargin");
73         get(mpTopMarginEdit, "topmargin");
74         get(mpBottomMarginEdit, "bottommargin");
75     
76         Initialize();
> > >     CID 1362175:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "mnPageBottomMargin" is not initialized in this constructor nor in 
> > > any functions that it calls.
77     }
78     
79     PageMarginPanel::~PageMarginPanel()
80     {
81         disposeOnce();
82     }

** CID 1362174:  Resource leaks  (RESOURCE_LEAK)
/formula/source/core/api/token.cxx: 1478 in formula::FormulaTokenArray::RewriteMissing(const 
formula::MissingConvention &)()


________________________________________________________________________________________________________
*** CID 1362174:  Resource leaks  (RESOURCE_LEAK)
/formula/source/core/api/token.cxx: 1478 in formula::FormulaTokenArray::RewriteMissing(const 
formula::MissingConvention &)()
1472             delete [] pOcas;
1473         if (pOcas != &aOpCodeAddressStack[0])
1474             delete [] pOcas;
1475         if (pCtx != &aCtx[0])
1476             delete [] pCtx;
1477     
> > >     CID 1362174:  Resource leaks  (RESOURCE_LEAK)
> > >     Variable "pOcds" going out of scope leaks the storage it points to.
1478         return pNewArr;
1479     }
1480     
1481     bool FormulaTokenArray::MayReferenceFollow()
1482     {
1483         if ( pCode && nLen > 0 )

** CID 1362173:  Null pointer dereferences  (FORWARD_NULL)
/sfx2/source/appl/appopen.cxx: 454 in SfxApplication::NewDocExec_Impl(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1362173:  Null pointer dereferences  (FORWARD_NULL)
/sfx2/source/appl/appopen.cxx: 454 in SfxApplication::NewDocExec_Impl(SfxRequest &)()
448             bool bNewWin = false;
449             vcl::Window* pTopWin = GetTopWindow();
450     
451             SfxObjectShell* pCurrentShell = SfxObjectShell::Current();
452             Reference<XModel> xModel;
453     
> > >     CID 1362173:  Null pointer dereferences  (FORWARD_NULL)
> > >     Comparing "pCurrentShell" to null implies that "pCurrentShell" might be null.
454             if(pCurrentShell)
455                 xModel = pCurrentShell->GetModel();
456     
457             ScopedVclPtrInstance< SfxTemplateManagerDlg > aTemplDlg;
458     
459             if(xModel.is())


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939