Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


--- a/vcl/opengl/win/gdiimpl.cxx
+++ b/vcl/opengl/win/gdiimpl.cxx
@@ -166,6 +166,7 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT
message, WPARAM wParam, LPARAM l
         case VK_SPACE:
             break;
         }
+        SAL_FALLTHROUGH; //TODO ???
     default:
         return DefWindowProc(hwnd, message, wParam, lParam);
     }


I did not write this code, but looking at it, it seems fairly obvious that
the fall-through is intentional here. But it is beyond my understanding why
such a temporary window, that is used only for some milliseconds, and never
even displayed, would need to handle the Escape and Space keys specially.

--tml

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.