Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


On 05/12/2016 01:46 PM, Caolán McNamara wrote:
On Thu, 2016-05-12 at 10:28 +0200, Stephan Bergmann wrote:
* Of course, there may be more lurking in (platform-specific, etc.)
code that hasn't yet been built with Clang.  (I enabled
-Wimplicit-fallthrough also for clang-cl on Windows, but haven't done
a build with it yet.)

Is this "__fallthrough" thing in Microsofts SAL Annotation Language
thing any use to us here ?
https://msdn.microsoft.com/en-us/library/ms235402%28VS.80%29.aspx

Ah, interesting. But hard to tell from that documentation where exactly the __fallthrough is supposed to go, i.e., whether a single SAL_FALLTHROUGH macro would work for both Clang and MSVC.

Failing that, the shorter-term measure for Windows-only code will be clang-cl (I'll see to get a fresh build going there soon), and the longer-term measure will be C++17 [[fallthrough]] (and presumably some MSVC warning flag to actually trigger warnings for un-annotated fall-throughs).

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.