Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


On Thu, Nov 19, 2015 at 3:20 AM, Ashod Nakashian <ashnakash@gmail.com> wrote:

Sorry, I didn't explain well.

The patches are related. They are updates based on feedback, partial failure
or improvement.

They aren't bulk pushes (whatever that means). They are updates on a single
changeset.

Why do people send multiple patches per push? That's the right question to
ask.

And the answer is: to improve the previous patch.

Wrong answer.
The very concept of change-set is that you can work on a patch and
rework it as necessary
there is absolutely no reason to create a second patch on top of a
faulty patch not merged yet.
what should be done is to rework the original patch.
It is the whole point of review-before-merge that gerrit offer.

Hence my question. If a patch has partially failed, or I got feedback to
improve it, or (insert reason here), and I want to push an update, why
should the previous patch still build when it's not necessary?

There should not be a previous patch at all.. you should amend it not
create another one on top of it

Norbert

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.