Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes

Stephan Bergmann <sbergman -AT- redhat.com>
Wed, 4 Nov 2015 11:56:10 +0100

On 11/04/2015 11:32 AM, jan iversen wrote:

On 4 November 2015 at 11:21, Norbert Thiebaud <nthiebaud@gmail.com
<mailto:nthiebaud@gmail.com>> wrote:
    you can choose size or perf.. but having a
    bool foo:1
    followed by 2 plain bool
    is wrong either way.

Correct, things like that make many compilers drop optimization for the
whole class.


Can you elaborate?

As a side note, also remember that when using initializers in the
constructor, while digging into the code I have seen a couple of places
where the
sequence of initializers do not match the declaration sequence.

That gets warned about by all relevant compilers (IIRC), so it wouldsurprise me if there are instances of that in the LO code base (whichshould routinely be built with --enable-werror).

Context

Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Stephan Bergmann
- Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Norbert Thiebaud
  - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · jan iversen
    - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Stephan Bergmann
      - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Norbert Thiebaud
  - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Stephan Bergmann
    - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Norbert Thiebaud
    - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Norbert Thiebaud
      - Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Stephan Bergmann
        
        Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Ashod Nakashian
        
        Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Bjoern Michaelsen
        
        Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Michael Stahl
        
        Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Norbert Thiebaud
        
        Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes · Riccardo Magliocchetti

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.