Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


On 10/26/2015 06:14 PM, Ashod Nakashian wrote:
As a transitional phase, we can maintain the same interface but with
std:atomic as the implementation.

osl/interlck.h is part of the stable URE interface. While the osl_atomic_inc-/decrement macros are marked as INTERNAL and should arguably not be called directly by external code, any changes to the file would need to be made in a way that it continues to work both as a C file and with C++03 compilers. I would suggest just leaving the file alone (unless there is evidence that performance improvement is required and possible for some scenario that needs to go through these macros).

However, outside the stable URE interface, there should be no good reason not to use C++11 atomics (assuming all relevant compilers support them fine by now).

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.