Re: [Libreoffice-commits] core.git: 2 commits - editeng/source svx/source

Eike Rathke <erack -AT- redhat.com>

Fri, 23 Oct 2015 17:40:28 +0200

Hi Caolán, On Friday, 2015-10-23 01:13:40 -0700, Caolán McNamara wrote:

-    LanguageType nTmpKey1 = eLang & 0x7ff, // the main language in many cases DE
-                 nTmpKey2 = eLang & 0x3ff; // otherwise for example EN
+    LanguageType nTmpKey1 = eLang & 0x7ff; // the main language in many cases DE

The mask 0x7ff looks wrong to me. The primary language ID mask is 0x3ff, using 0x7ff includes one bit of the sublanguage ID, that combination is (and was) somewhat arbitrary.. the old comment already had it wrong. Btw, we have LANGUAGE_MASK_PRIMARY, best to use it ;) Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: signature.asc
Description: PGP signature

Context

Re: [Libreoffice-commits] core.git: 2 commits - editeng/source svx/source · Eike Rathke

Re: [Libreoffice-commits] core.git: 2 commits - editeng/source svx/source · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.