Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


What was wrong about those two commits, that required reverting them?

On 06/23/2015 08:43 PM, Julien Nabet wrote:
commit 09b4cbe977c755a447f97034189b85998f358d79
Author: Julien Nabet <serval2412@yahoo.fr>
Date:   Tue Jun 23 20:42:13 2015 +0200

     Revert "Typo: repsent->represent"

     This reverts commit 338161a41d6e01b8e8d8752d9a38cc5c7a63f288.

diff --git a/bridges/test/java_remote/Bug107753_Test.java 
b/bridges/test/java_remote/Bug107753_Test.java
index 8dc4e5f..c83d5f1 100644
--- a/bridges/test/java_remote/Bug107753_Test.java
+++ b/bridges/test/java_remote/Bug107753_Test.java
@@ -32,7 +32,7 @@ import test.lib.TestBed;
   *
   * <p>Bug #107753# "Java UNO: Proxies should implement intuitive semantics of
   * equals and hashCode" requests that two proxies are equal if they represent
- * the same UNO object.  This implies that if two proxies represent the same UNO
+ * the same UNO object.  This implies that if two proxies repsent the same UNO
   * object, they must have the same hash code.</p>
   */
  public final class Bug107753_Test extends ComplexTestCase {
commit 262dbabe8e07f60d55461ab3fb2c26d37b86a311
Author: Julien Nabet <serval2412@yahoo.fr>
Date:   Tue Jun 23 20:41:33 2015 +0200

     Revert "Wrong comment with 'sal_True' instead of 'true'"

     This reverts commit abd7ad8bff9b1874e3903aa55f33ef887d95096a.

diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index caa7d09..9b4cc9f 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -1653,7 +1653,7 @@ uno::Sequence< lang::Locale > SAL_CALL
  static bool IsEqSvcList( const uno::Sequence< OUString > &rList1,
                          const uno::Sequence< OUString > &rList2 )
  {
-    // returns true if both sequences are equal
+    // returns sal_True if both sequences are equal

      bool bRes = false;
      sal_Int32 nLen = rList1.getLength();


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.