Re: [Libreoffice-commits] core.git: 7 commits - connectivity/source dbaccess/JunitTest_dbaccess_complex.mk dbaccess/qa dbaccess/source

Hi Lionel,

On Sat, May 30, 2015 at 08:34:13AM -0700, Lionel Elie Mamane <lionel@mamane.lu> wrote:
>  connectivity/source/drivers/hsqldb/HConnection.cxx |   13 +++++--
>  dbaccess/JunitTest_dbaccess_complex.mk             |    1 
>  dbaccess/qa/complex/dbaccess/RowSet.java           |   36 ++++++++++++++++-----
>  dbaccess/source/core/api/RowSet.cxx                |   25 ++++++--------
>  dbaccess/source/core/api/RowSet.hxx                |    3 -
>  dbaccess/source/core/api/RowSetBase.cxx            |    1 
>  6 files changed, 53 insertions(+), 26 deletions(-)
>
> New commits:
> commit 9b06d36571bbfa2d722f36610375e7cd24be81a7
> Author: Lionel Elie Mamane <lionel@mamane.lu>
> Date:   Sat May 30 17:08:49 2015 +0200
>
>     reenable JunitTest_dbaccess_complex part RowSet
>     
>     Change-Id: I82a1af0cd6b068e9f349ec6b068e78d55e8ab969
>
> diff --git a/dbaccess/JunitTest_dbaccess_complex.mk b/dbaccess/JunitTest_dbaccess_complex.mk
> index e3f2c00..7a0b17b 100644
> --- a/dbaccess/JunitTest_dbaccess_complex.mk
> +++ b/dbaccess/JunitTest_dbaccess_complex.mk
> @@ -27,6 +27,7 @@ $(eval $(call gb_JunitTest_set_defs,dbaccess_complex,\
>  $(eval $(call gb_JunitTest_add_classes,dbaccess_complex,\
>      complex.dbaccess.Beamer \
>      complex.dbaccess.PropertyBag \
> +    complex.dbaccess.RowSet \
>  ))

This last commit makes 'make check' fail debug-enabled Linux builds at
least, see
<http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/622/console>, I
also got that locally.

For now, I just re-disabled the RowSet part on master, please if you
would enable it again, first make sure that a debug 'make check' is
happy before pushing. :-)

Thanks,

Miklos

Attachment: signature.asc
Description: Digital signature