Re: shouldn't XFoo implementations use sal_Bool, and not bool?

On 05/30/2015 10:30 PM, Lionel Elie Mamane wrote:
>           virtual ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XClob > SAL_CALL 
> getClob( sal_Int32 columnIndex ) throw(::com::su
>           virtual ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XArray > SAL_CALL 
> getArray( sal_Int32 columnIndex ) throw(::com::
>           // ::com::sun::star::sdbc::XResultSet
> -        virtual sal_Bool SAL_CALL next(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> -        virtual sal_Bool SAL_CALL isBeforeFirst(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> -        virtual sal_Bool SAL_CALL isAfterLast(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> -        virtual sal_Bool SAL_CALL isFirst(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> -        virtual sal_Bool SAL_CALL isLast(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> +        virtual bool SAL_CALL next(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> +        virtual bool SAL_CALL isBeforeFirst(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> +        virtual bool SAL_CALL isAfterLast(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> +        virtual bool SAL_CALL isFirst(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
> +        virtual bool SAL_CALL isLast(  ) throw(::com::sun::star::sdbc::SQLException, 
> ::com::sun::star::uno::RuntimeException);
>
>
> Which changed dbaccess/source/core/api/CacheSet.hxx to bool return
> types. But these are (copies of) the com::sun::star::sdbc::XResultSet
> interface, so shouldn't those have stayed sal_Bool?

The functions are apparently copied from XResultSet (incl. presumably 
unnecessary virtual and SAL_CALL, even), but technically they are 
unrelated.  That means there is no technical reason to make them use the 
inferior sal_Bool instead of bool (and loplugin:salbool should warn 
about such unnecessary uses of sal_Bool).