Re: Issue with bundled commons-codecs and commons-lang

2015-04-23 15:58 GMT+02:00 Michael Stahl <mstahl@redhat.com>:

> On 23.04.2015 10:41, Tomáš Chvátal wrote:
> > Hello everybody,
> >
> > I am having problem with the 4.4 libreoffice build with bundled libs.
> >
> > The commons-codecs and commons-lang error out on me with following error:
> >
> > [23259s] ERROR: the files below contain java bytecode for something
> > later than java 1.5,
>
> uhm - *why* exactly is JRE 1.6 byte code an error???

Dunno, SLE11 is this nicely old beast :)

> > [23259s] ERROR: please set the javac target to 1.5 or lower.
> > [23259s] commons-codec-1.9.jar:
> org/apache/commons/codec/StringEncoder.class
> > [23259s] commons-codec-1.9.jar:
> > org/apache/commons/codec/DecoderException.class
> > ...
> > [23259s] commons-lang3-3.3.1.jar:
> > org/apache/commons/lang3/AnnotationUtils.class
> > [23259s] commons-lang3-3.3.1.jar:
> > org/apache/commons/lang3/text/StrLookup.class
> > ...
> >
> > If I am looking at it correctly it seems like these two are just
> > unpacked and the jar reused, instead of being recompiled like it was
> > done in past.
>
> really?  must be some downstream distro patch, that's not what upstream
> does, we build it with ant in
> external/apache-commons/ExternalProject_apache_commons_lang.mk  etc.
>
> (see in particular commit 89db5b5b88508e55bce50240d248dd26053f4e09,
> "Apache Commons Lang 3.3.1 at least requires Java 1.6 and non debug
> version")
Seems you are right it is compiled, the -source and -target are passed,
buuut I have to override by disabling HAVE_JAVA6 define.
The old versions of the lang/codec seem to work splendidly with the checker.

Thanks

Tom