Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


On Fri, Aug 29, 2014 at 11:58:48AM +0200, Thorsten Behrens wrote:
Jörg Sonnenberger wrote:
+        SurfaceSharedPtr surface(mpOwningSpriteCanvas->getBufferSurface());
         ::std::for_each( aUncoveredAreas.begin(),
                          aUncoveredAreas.end(),
                          ::boost::bind( &repaintBackground,
                                         boost::cref(pCompositingCairo),
-                                        boost::cref(mpOwningSpriteCanvas->getBufferSurface()),
+                                        boost::cref(surface),
                                         _1 ) );

If you need a local variable anyway - why not insted getting rid of
the boost::cref and pass the parameter by value in the first place?

e.g. , mpOwningSpriteCanvas->getBufferSurface(), _1 ... ?

Haven't tried, was looking for the minimal change to the existing
structure. One thing to keep in mind is that getBufferSurface() creates
a temporary variable. It doesn't return a reference itself.

Joerg

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.