On 06/13/2014 03:09 PM, Lionel Elie Mamane wrote:
So, one question is, what is the LibreOffice "coding standard" for
"internal inconsistency"? Do we have a specific exception for that, do
we rather abort() (in debug mode) and return "no value / empty value /
0" to the caller?
From what you describe, it sounds like:
* 706317 throws only if the JRE installation is broken. I'd use some
sort of UNO runtime exception for that, like css.uno.DeplyomentException.
* 706361 throws only in case of a LO programming error. I'd use (in
order from most to least preferred) (a) assert or std::abort (the latter
in case the failing code would need to produce a non-void result; blurry
here whether or not to consider the _rValue reference as needing to be
assigned a value); (b) throw a std::logic_error (esp. now that we added
std::exception to all the UNO functions' dynamic exception
specifications); or (c) throw some UNO runtime exception.
Stephan
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.