Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index 

On 05/23/2014 10:24 PM, julien2412 wrote:

After lots of changes, there are still Sequence cases + things like:
::getCppuType(&m_sFilter));

just to be sure, should it replaced by "cppu::UnoType< type of m_sFilter
> ::get();" ?
As both getCppuType and UnoType operate on the static type, there is at least no technical reason not to replace that. There might be the rare case where the former makes for easier reading and maintenance of the code, but at least in dbaccess/source/core/api/table.cxx, the list is already non-uniform anyway, mixing getCppuType, getBooleanCppuType, UnoType, so I'd just clean it up to consistently use UnoType. 


Also, are there special cases to take into account for these?
There should be no gotchas other then the sequence of char vs. unsigned short issue. At least, none come to mind. 

Stephan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.