Re: Cppcheck reports 'else if' condition matches previous condition (svx)

Caolán McNamara <caolanm -AT- redhat.com>
Fri, 11 Apr 2014 12:20:49 +0100

On Tue, 2014-04-08 at 20:58 +0200, Julien Nabet wrote:

I've just pushed the fix on master. "make check" on top level was ok.
Searching in git history during "make check", I found this commit from 2008:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d20a47c3d50d0a88543b2355ec7340fc7455984
which references "OBJ_TABLE"
whereas OBJ_OLE2 was in 2001 (see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e24bc241b69da6789351d9bf82eab5119f09c16c) 


I submitted a gerrit review 4.2:
https://gerrit.libreoffice.org/8897


I'm rather reluctant to change this in 4.2 without a specific known
problem that it fixes.

C.

Context

Cppcheck reports 'else if' condition matches previous condition (svx) · julien2412
- Re: Cppcheck reports 'else if' condition matches previous condition (svx) · Caolán McNamara
  - Re: Cppcheck reports 'else if' condition matches previous condition (svx) · Julien Nabet
    - Re: Cppcheck reports 'else if' condition matches previous condition (svx) · Caolán McNamara
      - [SOLVED] Re: Cppcheck reports 'else if' condition matches previous condition (svx) · Julien Nabet

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.