Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


Hello,

Cppcheck reported this
svx/source/unodraw/unomod.cxx
492     multiCondition  style   Expression is always false because 'else if'
condition matches previous condition at line 460.

Remark: It's a new kind of cppcheck detection and there are quite a lot of
false positives (at least for LO) for the moment.

Here's the code:
    460         else if( aTypeName.startsWith( "TableShape" ) )
    461         {
    462             nType = OBJ_OLE2;
    463         }
...
    492         else if( aTypeName.startsWith( "TableShape" ) )
    493         {
    494             nType = OBJ_TABLE;
    495         }

see
http://opengrok.libreoffice.org/xref/core/svx/source/unodraw/unomod.cxx#460

Which one of this block is ok?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-reports-else-if-condition-matches-previous-condition-svx-tp4104268.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.