Re: Fwd: Re: [Libreoffice-commits] core.git: Move string hash function into String class.

On 02/14/2014 08:07 PM, Stephan Bergmann wrote:
> On 02/14/2014 03:24 PM, Muthu Subramanian wrote:
> > How else would we build a hash value without too much work?
>
> If you have a structure consisting of multiple parts, compute hash 
> values for the individual parts and fold them into a single hash value 
> via some suitable function, like f(x, y) = px + y for some prime p.
Ah...that's what I meant by reusing the hash. Even in which case, there 
might be places where we might need large strings (may not make sense to 
break them smaller).
(E.g. SfxItemSet - its nicer to handle it as a group rather than 
individual Items)

> > I have added a hash for SfxItemSet as well recently. (Next step would
> > be to reuse that hash in SdPage, of course).
>
> ...which I had just identified as dead code.  ;)  Please never 
> introduce unused code.  (And those stringify/hashCode functions 
> apparently also don't need to be virtual.)
Which one, please? Maybe we are referring to different parts of the 
code? I am not aware of dead code per se :(
hmm... I thought I marked them virtual - maybe not for SdPage - I didn't 
think SdPage required virtual?

Thanks!
Muthu Subramanian

> Stephan