Hi Stephan,
a) Not sure what other things depend on hashCode - I assumed the
functions which call that
are ok with sampling based hash and needs it quick?
b) argh :( I added the rtl parts, I guess I missed the helper part -
will do.
c) Oops will change that
d) Will add this as well
e) this one as well.
I will do the changes depending on (a) - what would you prefer, please?
Should I just fix hashCode()?
There is specific code there to do the sampling - I thought that was
intended?
If you ask me, I would prefer to do it separately - like I have done it now.
64bit vs 32bit: I guess its a matter of choice and 64bit is better
indeed, but not sure about the value addition :(
Maybe, 32bit is sufficient.
(Btw, the intended use of this function is to actually hash many (or
most) of the objects)
PS: I am CC'ing the list for complicity - please feel free to drop it
while replying.
Thanks!
Muthu Subramanian
On 02/14/2014 02:59 PM, Stephan Bergmann wrote:
Ach, meant to send this to you instead of the mailing list...
-------- Original Message --------
Subject: Re: [Libreoffice-commits] core.git: Move string hash function
into String class.
Date: Fri, 14 Feb 2014 10:12:38 +0100
From: Stephan Bergmann <sbergman@redhat.com>
To: libreoffice@lists.freedesktop.org
Hi Muthu,
tried to reach you on IRC yesterday:
Feb 13 11:03:42 <sberg> muthusuba,
8f8bc0dcf3bc253ae49159d52db049767f476ced is broken: (a) the general
O[U]String::hashCode does sampling-only by design; if that's not
considered good these days we should change the implementation rather
than add another function (is 64-bit vs. 32-bit hash code of any
added value? doubt it given most hash maps will not be too big,
anyway); (b) adding OString::hashCode64 but not OUString::hashCode64?
(c) rtl_str_hashCode64_WithLength must
Feb 13 11:03:42 <sberg> go into a LIBO_UDK_4.3 section in sal.map,
not UDK_3_0_0; (d) rtl_ustr_hashCode64_WithLength missing from
sal.map; (e) missing @since tags
Stephan
Context
Re: [Libreoffice-commits] core.git: Move string hash function into String class. · Norbert Thiebaud
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.