Re: long paras + tools/string.hxx

Hi all,

On Tue, 21 Jan 2014 12:10:40 +0000
Caolán McNamara <caolanm@redhat.com> wrote:

> The 16 bit length limitation in writer is now removed towards 4.3.
>
> The 16 bit paragraph length limit in editeng still remains, editeng
> mixes freely sal_uInt16 with xub_StrLen and has a pile of hard-coded
> 0xFFFF here and there which makes it tricky to see at a glance which
> values are string lengths and offsets and which are not. Sigh.

I'l (very) slowly working on this. Indeed there are some obscure (to me) points in which I don't 
know how to proceed.
I will push to gerrit for review, just to have some cross checks, and the first bunch of patches 
should be ready in the next few days.

BTW: is there any chance that some use of sal_uInt16 is left behind in the already converted code? 
I'm asking just to know what to focus on after this task is finally done.

Thanks
Matteo

> Also, note there is a hidden limit in tools/stream.hxx of 0xFFFE in
> things like ReadLine and ReadByteStringLine and their callers.
>
> sc is now the only module that includes tools/string.hxx and uses
> STRING_MAXLEN. It would be great if some calc hackers could have a look
> there to see if those limits still make sense (e.g.
> nArbitraryLineLengthLimit) especially considering the ReadLine, etc.
> issue.
>
> C.
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice