Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


Hi Sven,

I hope Stephan does not mind I chime in on this. I am in the same
situation: still wanting to contribute, but not investing too much free
time.

How to call a developer's attention to small pieces of code?


In my experience the developers already know about that and there's no need
to worry.
I know these weird macros create an itch one really would like to tackle
right away, but it's just not worth the trouble if you can't/don't want to
compile.

If, however, you find a "2do" or a "Sollte noch optimiert werden" feel free
to append a TODO/FIXME.


And especially: may I combine that with translation patches?


Keep in mind that a commit should be concise and as much as possible
constrained to what the commit message says.
That way people can keep the quality work (translation of a language they
don't understand) from the "clean up the mess" work.

In most of my commits I translate and remove the ASCII art as that yields a
lot of benefits.

BTW: It's good practice to at least run ./autogen.sh before commiting (that
catches these nasty syntax errors).
See here for more:
https://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines#Keep_German_comment_translation_separate

Cheers,
Philipp

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.