[SOLVED] Re: cppcheck: Same expression in chartexport.cxx (oox module)

Julien Nabet <serval2412 -AT- yahoo.fr>

Sat, 14 Dec 2013 13:31:31 +0100

On 14/12/2013 07:02, Markus Mohrhard wrote:

Hey,


2013/12/13 julien2412 <serval2412@yahoo.fr <mailto:serval2412@yahoo.fr>>

    Hello,

    Cppcheck reported this:
    [oox/source/export/chartexport.cxx:1822] ->
    [oox/source/export/chartexport.cxx:1822]: (style) Same expression
    on both
    sides of '=='.

    Indeed we have:
       1822         if (aValues[i] == aValues[i])
       1823             pFS->write( aValues[i] );
     see
    http://opengrok.libreoffice.org/xref/core/oox/source/export/chartexport.cxx#1790
    (at this moment)

    I thought first about == overloading but didn't find it (or missed it)

    Any idea?

Actually that code is correct. This check prevents writing out NaNbecause NaN is not equal to itself. However I'll change it later tomake cppcheck happy.

Hello Markus,

Thank you for

:-)

Julien

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.