Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hello,

Cppcheck reported this:
[sw/source/ui/docvw/edtwin.cxx:3322] ->
[sw/source/ui/docvw/edtwin.cxx:3322]: (style) Same expression on both sides
of '&&'

Indeed we have:
   3319                         // if the cursor position was corrected or
if a Fly
   3320                         // was selected in ReadOnlyMode, no word
selection.
   3321                         if ( !bValidCrsrPos ||
   3322                             (rSh.IsFrmSelected() &&
rSh.IsFrmSelected() ))
   3323                             return;

git history indicates it's like this since initial import in (2000-03-18)
Of course I could remove one rSh.IsFrmSelected() but not sure at all when
reading comment above.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-Same-expression-in-edtwin-cxx-sw-module-tp4088148.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.