Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi Tomofumi and Cedric,

I found that the next commit is bugous:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c2902ecbf135fae070ea032fa10a59bb76ec1b0
I have problem mostly with using the ApplyLineDashing method with scale
parameter (borderlineprimitive2d.cxx).
I know two reasons why this is wrong:
- The value of aScale.getLength() increase when text zoom is decrease,
while it should decrease too. So when the text (or content of the border)
is the smallest the dashed border's snippets are the biggest, which is a
bit weird.
- The whole borderline primitive is transformed before drawing, so no need
to change the size of snippets separately, because this happens during the
mentioned transformation. Additionally this change causes the borderline
changing all the time while zooming and not just the size, but the snippets
are also moving, which is a bit disturbing.

There is a small part of the patch, which make to draw hairline primitive,
when the line is solid (before only the width was checked). Maybe this part
fixed the original bug, because as I see the hairline primitive means a
solid line.

Best regards,
Tamás

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.