Hi Michael
On Tue, 27 Aug 2013 14:15:38 +0200
Michael Stahl <mstahl@redhat.com> wrote:
On 26/08/13 12:55, Matteo Casalin wrote:
Hi all,
I stumbled upon the following loop [1] on a Ring, which seems
wrong to me:
SwExtTextInput* pTmp = (SwExtTextInput*)mpExtInputRing;
do {
//
// do something that does not modify pTmp nor mpExtInputRing
//
} while( mpExtInputRing != (pTmp = (SwExtTextInput*)mpExtInputRing ) );
from my understanding it processes just mpExtInputRing item and then
exits. I think that it should be something like:
do {
//
// do something
//
pTmp = (SwExtTextInput*)pTmp->GetNext();
} while( pTmp!=mpExtInputRing );
Am I missing something, is the loop to to be fixed as suggested of to be
removed completely?
i think you are completely right, although i don't know why that
extended-input stuff would bother with rings in the first place - does
anybody really use input methods in multiple places simultaneously, or
what is the point of that?
I will submit a patch for the loop, although it will take some days.
I don't know the details and, if I remember correctly, that code is quite old, so it can be
something that is outdated.
Thanks!
Matteo
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.