Re: [Libreoffice-commits] core.git: Mark Base window titles for localisation

On 08/05/2013 12:07 PM, Gabor Kelemen wrote:
> commit 8f44fb5ee0bd21d192820ffd359504f6d1c68a52
> Author: Gabor Kelemen <kelemeng@ubuntu.com>
> Date:   Mon Aug 5 11:12:17 2013 +0200
>
>      Mark Base window titles for localisation
>
>      Change-Id: If876592729c695e5a0916df24873f17f2b1b0254
>      Reviewed-on: https://gerrit.libreoffice.org/5283
>      Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
>      Tested-by: Miklos Vajna <vmiklos@suse.cz>

But none of the properties below are marked as oor:loalized="true" in 
officecfg/registry/schema/org/openoffice/Setup.xcs, so those 
xml:lang="en-US" additions will effectively be just ignored.  (And 
changing Setup.xcs accordingly could be considered an incompatible 
change, so we need to be careful there, but it might well be the correct 
thing to do here, depending on what this commit actually wanted to achieve.)

Stephan

> diff --git a/officecfg/registry/data/org/openoffice/Setup.xcu 
> b/officecfg/registry/data/org/openoffice/Setup.xcu
> index 1d7961b..50bdb21 100644
> --- a/officecfg/registry/data/org/openoffice/Setup.xcu
> +++ b/officecfg/registry/data/org/openoffice/Setup.xcu
> @@ -335,7 +335,7 @@
>             <value>swform</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Database Form</value>
> +          <value xml:lang="en-US">Base: Database Form</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryWindowStateConfigRef">
>             <value>WriterFormWindowState</value>
> @@ -370,7 +370,7 @@
>             <value>swreport</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Report Design</value>
> +          <value xml:lang="en-US">Base: Report Design</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryWindowStateConfigRef">
>             <value>WriterReportWindowState</value>
> @@ -481,7 +481,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Relation Design</value>
> +          <value xml:lang="en-US">Base: Relation Design</value>
>           </prop>
>         </node>
>         <node oor:name="com.sun.star.sdb.QueryDesign" oor:op="replace" install:module="base">
> @@ -506,7 +506,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Query Design</value>
> +          <value xml:lang="en-US">Base: Query Design</value>
>           </prop>
>         </node>
>         <node oor:name="com.sun.star.sdb.ViewDesign" oor:op="replace" install:module="base">
> @@ -531,7 +531,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: View Design</value>
> +          <value xml:lang="en-US">Base: View Design</value>
>           </prop>
>         </node>
>         <node oor:name="com.sun.star.sdb.TableDesign" oor:op="replace" install:module="base">
> @@ -556,7 +556,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Table Design</value>
> +          <value xml:lang="en-US">Base: Table Design</value>
>           </prop>
>         </node>
>         <node oor:name="com.sun.star.sdb.DataSourceBrowser" oor:op="replace" install:module="base">
> @@ -581,7 +581,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Data View</value>
> +          <value xml:lang="en-US">Base: Data View</value>
>           </prop>
>         </node>
>         <node oor:name="com.sun.star.sdb.TableDataView" oor:op="replace" install:module="base">
> @@ -606,7 +606,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Table Data View</value>
> +          <value xml:lang="en-US">Base: Table Data View</value>
>           </prop>
>         </node>
>         <node oor:name="com.sun.star.frame.Bibliography" oor:op="replace">
> @@ -773,7 +773,7 @@
>             <value>GenericCategories</value>
>           </prop>
>           <prop oor:name="ooSetupFactoryUIName">
> -          <value>Base: Oracle Report Builder</value>
> +          <value xml:lang="en-US">Base: Oracle Report Builder</value>
>           </prop>
>         </node>
>       </node>