Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


2013/7/8 Miklos Vajna <vmiklos@vmiklos.hu>

On Sun, Jul 07, 2013 at 11:19:11AM -0700, =?ISO-8859-1?Q?Zolnai_Tam=E1s_ <
zolnaitamas2000@gmail.com>, ?= wrote:
+    // character borders
+    editeng::SvxBorderLine*     m_pTopBorder;
+    editeng::SvxBorderLine*     m_pBottomBorder;
+    editeng::SvxBorderLine*     m_pRightBorder;
+    editeng::SvxBorderLine*     m_pLeftBorder;
+
....
+void SwFont::SetLeftBorder( const editeng::SvxBorderLine* pLeftBorder )
+{
+    delete m_pLeftBorder;
+    if( pLeftBorder )
+        m_pLeftBorder = new editeng::SvxBorderLine(*pLeftBorder);
+    else
+        m_pLeftBorder = 0;
+    bFntChg = sal_True;
+}

Hmm, what's the benefit or manual memory management here? If you need a
pointer, you could use boost::shared_ptr here. Though I'm not sure you
really need a pointer here. If you just want optional members,
boost::optional is better.


You're right, boost::optional will be better. I'll correct it.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.