Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hello,

Cppcheck reported this:
<error file="fpicker/source/win32/filepicker/WinFileOpenImpl.cxx" line="994"
id="redundantAssignment" severity="style" msg="Variable 'edt1Id' is
reassigned a value before the old one has been used."/>

    988         sal_Int32 edt1Id = edt1;
    989 
    990         // under W2k the there is a combobox instead
    991         // of an edit field for the file name edit field
    992         // the control id of this box is cmb13 and not
    993         // edt1 as before so we must use this id
    994         edt1Id = cmb13;

Since we don't support anymore isWin2000 (removed by
b30f91c58419e90a789f79a1391b13f2064997ab, 2011/07/20) , according to the
comment shouldn't it be:
  sal_Int32 edt1Id = edt1;
instead ?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-reassignment-of-edt1Id-because-isWin2000-has-been-removed-fpicker-module-tp4061342.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.