Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4020

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/4020/1

Fix memory leak in DrawViewShell::GetAttrState().

DrawViewShell::GetAttrState() might create a temporary new SvxNumRule
object. Make sure it gets deleted when done.

Change-Id: I33ddd9df983193fe87dd076267043d202cdfc3d5
---
M sd/source/ui/view/drviewsf.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/sd/source/ui/view/drviewsf.cxx b/sd/source/ui/view/drviewsf.cxx
index 4989cd2..89c90d0 100644
--- a/sd/source/ui/view/drviewsf.cxx
+++ b/sd/source/ui/view/drviewsf.cxx
@@ -630,9 +630,10 @@
                             }
                         }
                     }
+                  delete pNumRule;
                 }
             }
-                    break;
+            break;
             //End
             // Added by Li Hui for story 179.
             case FN_NUM_BULLET_ON:

-- 
To view, visit https://gerrit.libreoffice.org/4020
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33ddd9df983193fe87dd076267043d202cdfc3d5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark@klomp.org>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.