Re: Font family case-sensitiveness

Stephan Bergmann <sbergman -AT- redhat.com>

Wed, 22 May 2013 11:09:59 +0200

On 05/20/2013 03:35 PM, Caolán McNamara wrote:

On Sun, 2013-05-19 at 18:24 +0200, Thomas Arnhold wrote:

And maybe there is more work with GetFamilyName()..., see
79e5615fa103a52ce41ed682b624c13fd9a9d1eb.


Well, its kind of weird to have a test to see if the names are the same,
before going on to see if their foldedcase versions are the same too.
if( rFontName == GetFamilyName() ||
rFontName.equalsIgnoreAsciiCase( GetFamilyName() ) )
the OUString::equalsIgnoreAsciiCase does a (if both-share-the-ptr) opt
so I suggest you make those just into

if (rFontName.equalsIgnoreAsciiCase(GetFamilyName())) ?

I already addressed that with

"Redundant check" while working my way through the commit list backlog

ahead of working my way through the dev list backlog.

Stephan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.