On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
The attached patch is not in logerrit (I've yet to set that up), and
there's an error in it so I'm hoping someone can help. It does a TODO in
the file, but I can't get my argument casting right - in the original
code, matchIgnoreAsciiCaseAsciiL wraps its argument in
RTL_CONSTASCII_STRINGPARAM. This is defined in sal/inc/rtl/string.h and
passes both the string and its length. So me removing it is obviously a
mistake, but it's got some integrity checking in there and I just can't
get it to pass that.
RTL_CONSTASCII_STRINGPARAM is a hack/optimisation specific to
compile-time constants. With your change, the string is not anymore a
compile-time constant, so just use
equalsIgnoreAsciiCaseAscii()
--
Lionel
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.