Re: patch for postgresql driver

The macro is there to calculate the size of the string at compile time, 
which is normally a useful optimisation.

But given how you are changing the code, that optimisation is no longer 
possible, at least not without pre-calculating it and storing it in 
another array, which I don't think is warranted in this case.

On 2013-04-16 16:44, Wols Lists wrote:
> On 16/04/13 15:38, Noel Grandin wrote:
> > On 2013-04-16 16:16, Wols Lists wrote:
> > > if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j] ))
> > Surely this will work:
> >
> >      if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j],
> > strlen( keyword_list[j] )))
> I'll have a play with that soon, it's just that that macro is presumably
> there for some purpose, (plus the fact it converted one argument into 2
> :-) so I was being my usual self and playing cautious. I'll see what
> anybody else says, then try it.
>
> Cheers,
> Wol
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


Disclaimer: http://www.peralex.com/disclaimer.html