Hi Miklos,
Please, in the future, at least build-test your patch.
Regrets for the same.
This was the first time I didn't buid test as I thought I merely replaced
some 'compareTo' by '==' so I 'assumed' it should not be a problem. I
ensure you, this was my last time I did this mistake.
For now, I just fixed it for you, and pushed to master.
Thanks a lot :)
Also, please use the "[PATCH]" string in the subject of your mail, or
simply push the patch to gerrit:
I've been in habit of pushing my patches to gerrit and I'd done it many
times ago. It was just some ssh or ipmc access restriction from my server
side that I could not push to gerrit. Anyways I'll surely take care of the
fact, to prepend [PATCH] in future if I plan to mail my patch.
Thanks for guidance and patch review. :-)
Regards
Prashant
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.