Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi Prashant,

On Wed, Apr 10, 2013 at 06:04:50AM +0530, Prashant Pandey <prashant3.yishu@gmail.com> wrote:
I've attached a patch to get it reviewed.This patch implies some cleanup in
concern with bug#62096: Replace compareTo with '=='

This patch breaks the build here:

/home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx: In member function ‘long int 
FmXGridPeer::OnExecuteGridSlot(void*)’:
/home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx:2939:88: error: expected 
primary-expression before ‘||’ token
/home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx:2939:100: error: expected ‘;’ 
before ‘)’ token
make[1]: *** 
[/home/vmiklos/git/libreoffice/master/workdir/unxlngx6/CxxObject/svx/source/fmcomp/fmgridif.o] 
Error 1

Please, in the future, at least build-test your patch. For now, I just
fixed it for you, and pushed to master. Also, please use the "[PATCH]"
string in the subject of your mail, or simply push the patch to gerrit:

https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

that makes it easier for reviewers to notice your patch.

Thanks! :-)

Miklos

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.