Hi Prashant, On Wed, Apr 10, 2013 at 06:04:50AM +0530, Prashant Pandey <prashant3.yishu@gmail.com> wrote:
I've attached a patch to get it reviewed.This patch implies some cleanup in concern with bug#62096: Replace compareTo with '=='
This patch breaks the build here: /home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx: In member function ‘long int FmXGridPeer::OnExecuteGridSlot(void*)’: /home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx:2939:88: error: expected primary-expression before ‘||’ token /home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx:2939:100: error: expected ‘;’ before ‘)’ token make[1]: *** [/home/vmiklos/git/libreoffice/master/workdir/unxlngx6/CxxObject/svx/source/fmcomp/fmgridif.o] Error 1 Please, in the future, at least build-test your patch. For now, I just fixed it for you, and pushed to master. Also, please use the "[PATCH]" string in the subject of your mail, or simply push the patch to gerrit: https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch that makes it easier for reviewers to notice your patch. Thanks! :-) Miklos
Attachment:
signature.asc
Description: Digital signature