Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes

Miklos Vajna <vmiklos -AT- suse.cz>
Mon, 8 Apr 2013 20:43:30 +0200

Hi,

On Mon, Apr 08, 2013 at 05:36:54PM +0200, Stephan Bergmann <sbergman@redhat.com> wrote:

addressed for now with 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=21fea27309a75b86add08918d2a2a2234ae1f1fb>
"Make icu's DefaultCharMapper usable on Windows."


An additional problem was that this also broke the system-icu builds,
Rene already reverted it with
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=08ba028992a77dee32dd76030bc409c6d3b39e36>,
and also your patch with
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=2750142021c6f6b4b0e5e82a71a9f3f9cddbc400>.

Of course, the original question is still open: if we should duplicate
that class from ICU in LO code (to avoid using ICU internals) or there
is a better idea, since now fdo#60534 is a problem again.

Sorry for the trouble, needless to say I didn't test Windows or
system-icu build when reviewing the patch.

Miklos

Attachment: signature.asc
Description: Digital signature

Context

Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes · Stephan Bergmann
- Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes · Stephan Bergmann
  - Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes · Miklos Vajna

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.