Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes

Stephan Bergmann <sbergman -AT- redhat.com>
Mon, 08 Apr 2013 17:36:54 +0200

On 04/08/2013 05:15 PM, Stephan Bergmann wrote:

The below breaks on MSVC/Windows, against our internal icu 51.  Its
DefaultCharMapper (icu/source/layout/DefaultCharMapper.h) and
LECharMapper (icu/source/layout/LEFontInstance.h) it is derived from are
not marked as U_LAYOUT_API, so their non-inline function definitions
(esp., LECharMapper::~LECharMapper and DefaultMapper::mapChar) are not
exported on Windows.  They are virtual, so this wouldn't be a problem if
DefaultCharMapper were used in a way that function calls would
necessarily be resolved via vtable, but that's not the case in the below
code.

addressed for now with<http://cgit.freedesktop.org/libreoffice/core/commit/?id=21fea27309a75b86add08918d2a2a2234ae1f1fb>"Make icu's DefaultCharMapper usable on Windows."


Stephan

Context

Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes · Stephan Bergmann
- Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes · Stephan Bergmann
  - Re: [Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes · Miklos Vajna

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.