Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3136
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3136/1
fdo#62096 Replace O(U)String compareTo with ==
Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4
---
M framework/source/fwe/xml/toolboxdocumenthandler.cxx
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/framework/source/fwe/xml/toolboxdocumenthandler.cxx
b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
index 21a13e2..97ec8ce 100644
--- a/framework/source/fwe/xml/toolboxdocumenthandler.cxx
+++ b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
@@ -426,17 +426,17 @@
//fix for fdo#39370
/// check whether RTL interface or not
if(Application::GetSettings().GetLayoutRTL()){
- if (aCommandURL.compareTo(".uno:ParaLeftToRight") == 0)
+ if (aCommandURL == ".uno:ParaLeftToRight")
aCommandURL = ".uno:ParaRightToLeft";
- else if (aCommandURL.compareTo(".uno:ParaRightToLeft") == 0)
+ else if (aCommandURL == ".uno:ParaRightToLeft")
aCommandURL = ".uno:ParaLeftToRight";
- else if (aCommandURL.compareTo(".uno:LeftPara") == 0)
+ else if (aCommandURL == ".uno:LeftPara")
aCommandURL = ".uno:RightPara";
- else if (aCommandURL.compareTo(".uno:RightPara") == 0)
+ else if (aCommandURL == ".uno:RightPara")
aCommandURL = ".uno:LeftPara";
- else if (aCommandURL.compareTo(".uno:AlignLeft") == 0)
+ else if (aCommandURL == ".uno:AlignLeft")
aCommandURL = ".uno:AlignRight";
- else if (aCommandURL.compareTo(".uno:AlignRight") == 0)
+ else if (aCommandURL == ".uno:AlignRight")
aCommandURL = ".uno:AlignLeft";
}
--
To view, visit https://gerrit.libreoffice.org/3136
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Efe Gürkan Yalaman <efeyalaman@gmail.com>
Context
- [PATCH] fdo#62096 Replace O(U)String compareTo with == · via Code Review
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.