Hi,
I have submitted a patch for review:
    https://gerrit.libreoffice.org/3067
To pull it, you can do:
    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3067/1
coverity#982290 Logically dead code
Change-Id: Ia684369faa5fd0eb854d204ac7e8dbf74f032606
---
M connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx 
b/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
index ac8b50db..dbbec1e 100644
--- a/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
+++ b/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
@@ -448,8 +448,7 @@
     checkUpdate( columnIndex );
 
     Statics &st = getStatics();
-    if( x )
-        m_updateableField[columnIndex-1].value <<=  ( x ? st.TRUE : st.FALSE );
+    m_updateableField[columnIndex-1].value <<=  ( x ? st.TRUE : st.FALSE );
 
 }
 
-- 
To view, visit https://gerrit.libreoffice.org/3067
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia684369faa5fd0eb854d204ac7e8dbf74f032606
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412@yahoo.fr>
Context
- [PATCH] coverity#982290 Logically dead code · Julien Nabet (via Code Review)
 
   
 
  Privacy Policy |
  
Impressum (Legal Info) |
  
Copyright information: Unless otherwise specified, all text and images
  on this website are licensed under the
  
Creative Commons Attribution-Share Alike 3.0 License.
  This does not include the source code of LibreOffice, which is
  licensed under the Mozilla Public License (
MPLv2).
  "LibreOffice" and "The Document Foundation" are
  registered trademarks of their corresponding registered owners or are
  in actual use as trademarks in one or more countries. Their respective
  logos and icons are also subject to international copyright laws. Use
  thereof is explained in our 
trademark policy.