Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3066
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3066/1
fdo#42781 WaE: unreachable code
Encapsulate whole switch case code by #if
so it does not produce unreachable code when TRUE
Also found second occurence in function overload.
Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96
---
M sc/source/core/tool/interpr4.cxx
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index bfd9494..a3d77ff 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -543,10 +543,10 @@
break;
#if OSL_DEBUG_LEVEL > 0
case CELLTYPE_DESTROYED:
-#endif
SetError(errCellNoValue);
fValue = 0.0;
break;
+#endif
}
return fValue;
@@ -610,10 +610,10 @@
break;
#if OSL_DEBUG_LEVEL > 0
case CELLTYPE_DESTROYED:
-#endif
SetError(errCellNoValue);
fValue = 0.0;
break;
+#endif
}
return fValue;
--
To view, visit https://gerrit.libreoffice.org/3066
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Petr Kraus <petr_kraus@email.cz>
Context
- [PATCH] fdo#42781 WaE: unreachable code · Petr Kraus (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.