Re: [PATCH] fdo#51296:UI: Calc doesn't take care of security setting "Ctrl-click required to follow hyperlinks

Hi Akash,

first, congratulations for your first patch :-)

Akash Shetye píše v Ne 24. 03. 2013 v 01:24 +0530:
> Hi all,
>
> The patch takes the hyperlink security feature of SvtSecurityOptions
> into account while executing the ScGlobal::OpenURL method of calc to
> open URL in system browser. Because this is my first patch, I have put
> it on the mailing list, any suggestions are appreciated. Thank you.

The patch really causes that you need to use "CTRL-clink" to open the
link when "Tool/Options/LibreOffice/Security/Options/Ctrl-click required
to follow hyperlinks" is enabled. So, it is great!

I see that the method "cGlobal::OpenURL" is used on more locations in
the "sc" module, for example when you handle SID_OPEN_HYPERLINK. I can't
find what this means. I guess that it is a toolbar, menu, or dialog
entry. This call should probably ignore the security setting because it
is not the pure mouse click.

I add some Calc experts into CC. I hope that they could help :-)


Best Regards,
Petr


PS: It would be great to modify also the helper text that is shown when
you hover over the link. It currently shows the target URL. If you look
into Writer, it shows "Ctrl-click to open hyperlink: http://..."; I think
that it is related to STR_HYPERLINK_CLICK, see
source/ui/utlui/initui.src.