Re: [PATCH] remove/add blank lines in sw/source/core

Hi Eike,

On Thu, 2013-03-21 at 14:31 +0100, Eike Rathke wrote:
> On Wednesday, 2013-03-20 17:31:03 +0000, Philipp Riemer (via Code Review) wrote:
> > remove/add blank lines in sw/source/core
>
> I'd prefer if such mere cosmetical changes would not be done; while
> inserting a blank line mostly is ok for readability, removing a blank
> line mostly for the same reason decreases readability.

        :-) IMHO 2 newlines is reasonable if it is consistent: to me
inconsistency is more annoying than other things. OTOH - four spaces is
to my mind just silly eg.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=29b6eda7e5909106d8325f75b3ae0cda579385b5

>  After all it boils down to personal preferences. i.e. personally I
> usually use two blank lines between method implementations, just
> because browsing the source on a quick fly in the editor is easier
> for the eye.

        Seems reasonable to me; IMHO there is enough broken-ness around to not
go fixing whitespace - or at least removing double-line spaces between
methods in consistent calc files for now ;-)

        So I'd say that these huge spews of ascii-art don't serve a useful
purpose:

//-------------------------------------------------

        and bulky content-free comments (which we still have plenty of) should
clearly take be a higher priority for being removing ;-) at least to me.

        ATB,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot