Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2890
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2890/1
Move setupwizard modify handler code.
Move setupwizard code into the conditional below it. You can only work
on pPage if it isn't a null pointer anyway, to my mind this looks a
lot cleaner.
Change-Id: If8d910c15c5a1c1da5eb204b5922d074c454978b
---
M dbaccess/source/ui/dlg/dbwizsetup.cxx
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx b/dbaccess/source/ui/dlg/dbwizsetup.cxx
index 338e7c0..cb53dfd 100644
--- a/dbaccess/source/ui/dlg/dbwizsetup.cxx
+++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx
@@ -587,13 +587,13 @@
break;
}
- if (pPage && (_nState != PAGE_DBSETUPWIZARD_INTRO) && (_nState !=
PAGE_DBSETUPWIZARD_AUTHENTIFICATION))
- {
- pPage->SetModifiedHandler(LINK( this, ODbTypeWizDialogSetup, ImplModifiedHdl ) );
- }
-
if ( pPage )
{
+ if ((_nState != PAGE_DBSETUPWIZARD_INTRO) && (_nState !=
PAGE_DBSETUPWIZARD_AUTHENTIFICATION))
+ {
+ pPage->SetModifiedHandler(LINK( this, ODbTypeWizDialogSetup, ImplModifiedHdl ) );
+ }
+
pPage->SetServiceFactory( m_pImpl->getORB() );
pPage->SetAdminDialog(this, this);
--
To view, visit https://gerrit.libreoffice.org/2890
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8d910c15c5a1c1da5eb204b5922d074c454978b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock <chris.sherlock79@gmail.com>
Context
- [PATCH] Move setupwizard modify handler code. · Chris Sherlock (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.