Re: [PATCH] various .ui fixes caught by linter tool

On Mon, 2013-03-18 at 12:01 +0100, Lubos Lunak wrote:
> > On Fri, 2013-03-15 at 18:32 +0000, Jack Leigh (via Code Review) wrote:
> > > various .ui fixes caught by linter tool
> >
> >     Sounds really interesting :-) can we make the tool part of our build
> > process somehow ?
>
>  And do we need such a tool at all? If Glade is not capable of providing 
> sensible defaults for spacing and similar features, cannot our code for 
> loading the .ui files handle that?

        Not sure it's -that- easy, we can use the same widgets with different
padding around the place and/or may want to tweak that.

        Either way - IIRC we also want the linter to ensure that all strings
are marked translated to avoid the problems we had around 4.0.0 here.

        Jack - I guess a good place to put the lint tool might be in the
install rule for the .ui files:

        solenv/gbuild/UI.mk

        would be the place to add that; though it's not terribly clear
how/where - presumably the:

$(call gb_Package_Package_internal,$(1)_ui,$(SRCDIR))

        piece does something like that,

        Thanks !

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot