Re: help regarding bug 39445 - writing out tools/

On 03/05/2013 05:26 PM, Andras Timar wrote:
> On Tue, Mar 5, 2013 at 3:49 PM, Stephan Bergmann <sbergman@redhat.com> wrote:
> > On 03/04/2013 02:36 PM, Krisztian Pinter wrote:
> > > I've been tasked with this easyhack:
> > > https://bugs.freedesktop.org/show_bug.cgi?id=39445
> > >
> > > I started with this source, because it seemed easy enough:
> > >
> > > http://opengrok.libreoffice.org/xref/core/rsc/source/tools/rsctools.cxx#175
> >
> >
> > Code in rsc/source/tools (despite the "tools" in the path) is not what
> > <https://bugs.freedesktop.org/show_bug.cgi?id=39445> "write tools/ pieces
> > out" talks about.
>
> That's right, Krisztian wanted to replace types defined in
> tools/fsys.hxx with types defined in osl/file.hxx. At
> http://opengrok.libreoffice.org/xref/core/rsc/source/tools/rsctools.cxx#175
> DirEntry::SetExtension() member function is used, and he did not find
> similar member function in sal.

Ah, my bad.  I was confused by looking at line 175 and not line 181.  As 
the sal/osl file abstraction stuff is URI based, such functionality 
would probably best fit with (generic) URI handling code.  There's 
low-level functionality at rtl/uri.h[xx] and UNO-based functionality at 
com.sun.star.uri.UriReferenceFactory idl, neither of which offers any 
"set extension" functionality, though, and there's tools/urlobj.hxx, 
which does offer such functionality, but would kinda lead back to square 
one.

> > The rsc module implements a resource compiler for .src/.hrc files
> > (thankfully obsoleted now by moving to .ui files), see rsc/README.
>
> Is this true? AFAIK only dialogs are moving to .ui, strings,
> messageboxes etc. stay in .src.

Yeah, that's right, I guess.  (Though one would hope that that 
eventually gets replaced as well, to reduce the number of different 
concepts?)

Stephan