On Thu, Feb 28, 2013 at 11:34:24AM +0000, Caolán McNamara wrote:
caolanm->bjoern: what's the vision around SfxItemSet::DisableItem and
removal of the two argument SfxItemSet::Put ?
Both tie the interface of the class to the implementation. If one wants to
replace the SfxItemSet someday with some same standard container internally,
these two are the first to go.
Also: The two argument SfxItemSet::Put allows you to put an item at WhichId
slot that is different from the WhichId the SfxPoolItem has stored internally,
thus following the principle of most surprise. This is e.g. done in editeng
quite a lot. I expect quite a few obscure bugs will be created by this
implementation detail ... wait, let me rephrase that: I expect quite a few
obscure bugs already existing because of this. ;)
Best,
Bjoern
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.