Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Caolán McNamara wrote
On Tue, 2013-02-12 at 05:58 -0800, julien2412 [via Document Foundation
Mail Archive] wrote:
        Caolán McNamara wrote
        So, unless Rafael has other plans, it looks to me that you can
        remove the bContainsDate lines, the aDT = lines, and the
        getPropertyValue(..) 
        >>= aDT block.
I don't know if you received some information from Raphael but if we
remove aDT variable, does it also mean this whole block can be
removed? 

    147                     if ( bHasTargetURL && 
    148                         INetURLObject( aContentURL
).GetProtocol() == INET_PROT_VND_SUN_STAR_HIER ) 
    149                     { 
    150                         ucbhelper::Content aCnt( aTargetURL,
m_xCmdEnv, comphelper::getProcessComponentContext() ); 
    151 
    152                         try 
    153                         { 
    154
aCnt.getPropertyValue("DateModified") >>= aDT; 
    155                         } 
    156                         catch (...) 
    157                         {} 
    158                     } 

or does the call to Content constructor initialize something that I
missed

I heard nothing from Rafael and as far as I can see the whole block can
go, i.e. the ucbhelper::Content ctor has no side effects.

I pushed a commit on master about this, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bdd78dc3122bdc1eaf85f05fc3cb1cb9afedf7d

Julien





--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-bContainsDate-not-read-in-templateremoteview-cxx-sfx2-tp4032416p4040560.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.