Hello,
I translated the (only) german comment in the file
dtrans/source/win32/clipb/WinClipbImpl.cxx
Regards
Urs
From 7454d8ad180504ea2e50a52fe4a08ebc329db33f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Urs=20F=C3=A4ssler?= <urs@bitzgi.ch>
Date: Thu, 14 Feb 2013 18:17:44 +0100
Subject: [PATCH] Translation of german comment
Change-Id: I2876e33ccfd5dd7b33747d77a4cdaaa03bd01de9
---
dtrans/source/win32/clipb/WinClipbImpl.cxx | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/dtrans/source/win32/clipb/WinClipbImpl.cxx b/dtrans/source/win32/clipb/WinClipbImpl.cxx
index 167e889..ff89e14 100644
--- a/dtrans/source/win32/clipb/WinClipbImpl.cxx
+++ b/dtrans/source/win32/clipb/WinClipbImpl.cxx
@@ -180,16 +180,15 @@ sal_Int8 SAL_CALL CWinClipbImpl::getRenderingCapabilities( ) throw(
RuntimeExce
void SAL_CALL CWinClipbImpl::flushClipboard( ) throw( RuntimeException )
{
- // sollte eigentlich hier stehen: ClearableMutexGuard aGuard( m_ClipContentMutex );
- // geht aber nicht, da FlushClipboard zurückruft und das DataObject
- // freigibt und damit würde es einen Deadlock in onReleaseDataObject geben
- // FlushClipboard muß synchron sein, damit das runterfahren ggf. erst weitergeht,
- // wenn alle Clipboard-Formate gerendert wurden
- // die Abfrage ist nötig, damit nur geflusht wird, wenn wir wirklich Clipboardowner
- // sind (ich weiss nicht genau was passiert, wenn man flusht und nicht Clipboard
- // owner ist).
- // eventuell kann man aber die Abfrage in den Clipboard STA Thread verlagern, indem
- // man sich dort das DataObject merkt und vor dem flushen OleIsCurrentClipboard ruft
+ // actually it should be ClearableMutexGuard aGuard( m_ClipContentMutex );
+ // but it does not work since FlushClipboard does a callback and frees DataObject
+ // which results in a deadlock in onReleaseDataObject.
+ // FlushClipboard had to be synchronous in order to prevent shutdown until all
+ // clipboard-formats are rendered.
+ // The request is needed to prevent flushing if we are not clipboard owner (it is
+ // not known what happens if we flush but are not clipboard owner).
+ // It may be possible to move the request to the clipboard STA thread by saving the
+ // DataObject and call OleIsCurrentClipboard before flushing.
if ( NULL != m_pCurrentClipContent )
m_MtaOleClipboard.flushClipboard( );
--
1.7.10.4
Context
- [PATCH] translation of german comment in file dtrans/source/win32/clipb/WinClipbImpl.cxx · Urs Fässler
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.