[SOLVED] Re: Cppcheck: "bEmbed" always false -> block never called in fillinfo.cxx (sc module)

Julien Nabet <serval2412 -AT- yahoo.fr>
Mon, 11 Feb 2013 23:06:51 +0100

On 11/02/2013 18:43, Eike Rathke wrote:

Hi julien2412,

On Monday, 2013-02-11 03:05:42 -0800, julien2412 wrote:

Cppcheck reported this:
sc/source/core/data/fillinfo.cxx
507     variableScope   style   The scope of the variable 'bEmbed' can be reduced.

That's a leftover from 732f3546c4051d92e544df6462022e7d07765e83
Assuming that aa8e8c6bed0824d4840ed35a676dd570264fc543 indeed was the
result of a positive clang warning we're good that far, whyever bEmbed
was hard set to false initially and does not evaluate bIsEmbedded and
aEmbedRange anymore.. that was 291c919cf98347703e7ad2216b2b79aacd7cdfac
in 2004 and "#i25238# Support for inplace editing - please ask MBA" ;-)
I guess we'll live with that..

So, just remove the   else if (bEmbed)   block.

Thank you for your feedback and for having investigated about this. Ihad noticed the first commit but hadn't kept on.

I pushed the fix on master, seehttp://cgit.freedesktop.org/libreoffice/core/commit/?id=9e5e1dc6897bcdd81d86282f2df86d762d462972


Julien

Context

Cppcheck: "bEmbed" always false -> block never called in fillinfo.cxx (sc module) · julien2412
- Re: Cppcheck: "bEmbed" always false -> block never called in fillinfo.cxx (sc module) · Eike Rathke
  - [SOLVED] Re: Cppcheck: "bEmbed" always false -> block never called in fillinfo.cxx (sc module) · Julien Nabet

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.