Hi julien2412, On Monday, 2013-02-11 03:05:42 -0800, julien2412 wrote:
Cppcheck reported this: sc/source/core/data/fillinfo.cxx 507 variableScope style The scope of the variable 'bEmbed' can be reduced.
That's a leftover from 732f3546c4051d92e544df6462022e7d07765e83 Assuming that aa8e8c6bed0824d4840ed35a676dd570264fc543 indeed was the result of a positive clang warning we're good that far, whyever bEmbed was hard set to false initially and does not evaluate bIsEmbedded and aEmbedRange anymore.. that was 291c919cf98347703e7ad2216b2b79aacd7cdfac in 2004 and "#i25238# Support for inplace editing - please ask MBA" ;-) I guess we'll live with that.. So, just remove the else if (bEmbed) block. Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
Attachment:
pgp_QHK9mevUi.pgp
Description: PGP signature