Re: [comment libreoffice-4-0] API CHANGE: unpublish com.sun.star.document.MediaDescriptor.

Moving this to the list.  I need some clarification.

On 02/07/2013 08:38 AM, Stephan Bergmann (via Code Review) wrote:
> Stephan Bergmann has posted comments on this change.
>
> Change subject: API CHANGE: unpublish com.sun.star.document.MediaDescriptor.
> ......................................................................
>
>
> Patch Set 1: I would prefer that you didn't submit this
>
> I would suggest to restrict API changes to major/minor releases as much as possible.

Sure, but we really *need* this change.  I'm not just randomly deciding 
which API to change today.  Besides, this is not really an API, it's 
just a service description that's there for informational purposes only. 
 All it does is describe what each properties are, and all listed 
properties are marked optional.

I just don't see the point of marking such definition "published".  And 
this will change in the future, and it already has in 4.0.

Also, I thought we'd agreed to give us some range of release cycles 
where we are allowed to make changes to the published API, or am I 
remembering wrong?

>  As this fix would only go into the LO 4.0.1 micro release, I would suggest not to commit this to 
> libreoffice-4-0.

I personally disagree there.  We already ignore some of these properties 
already, and use ones that are not there.  To me this property bag 
should've been an implementation detail, never to be published. But 
alas, it has.

  (It is already committed to master towards LO 4.1 anyway AFAIU, 
though the commit message lacks a "cherry-picked from" reference.)

And I'm confused about this comment.  Are we now required to include 
"cherry-picked form" in each cherry-picked commit?  I hope not.

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc